Add VCS metrics from Github receiver by christophe-kamphaus-jemmic · Pull Request #1383 · open-telemetry/semantic-conventions

christophe-kamphaus-jemmic · 2024-09-03T20:59:06Z

Changes

This PR adds the VCS metrics from the GitHub Receiver to Semantic Conventions.
These metrics are based on https://github.com/adrielp/opentelemetry-collector-contrib/blob/903eec5382352e4d663fadd2dc7f1cc1e37f62fd/receiver/githubreceiver/documentation.md

Merge requirement checklist

CONTRIBUTING.md guidelines followed.
- Sign CLA
Change log entry added, according to the guidelines in When to add a changelog entry.
- If your PR does not need a change log, start the PR title with [chore]
schema-next.yaml updated with changes to existing conventions.

TODO

Update docs/cicd/cicd-metrics.md after receiving changes from Proposal: Unify metric templates #1411

https://github.com/adrielp/opentelemetry-collector-contrib/blob/903eec5382352e4d663fadd2dc7f1cc1e37f62fd/receiver/githubreceiver/documentation.md

linux-foundation-easycla · 2024-09-03T20:59:11Z

The committers listed above are authorized under a signed CLA.

✅ login: christophe-kamphaus-jemmic / name: Christophe Kamphaus (a5eff73, 163e498, 41543cd, 4d8e3a9, ef91dfa, 30c8fdb, e174ef3, cfcdaf1, 347b15b, 700412a, 5a9ffe7, c232041, aab9f90, f712312, d2ce62f, 2da96a5, 8c2e8a7, afaa1f5, 592483f, 9bd4a95, 344eeed, a148a4e, b5c4660, 44a1c81, 15fe1fb, fc3096e, c5d68ee, 84b2b6a, 7d114d3, 238c764, 513ae8b, 3e122e8, dafdad7, 7f35251, b92cc08, 536a2a7, 137921c, b1d8ddc, 0e02a47, 1a89934, 8f8bb73, 7107911, df9e0e4, 5d5a56b, 46d6194, 74363d8, ee9af4a, cfffb4f, 4a88a15, 879f9f1, f00fced, d549367, ae7d380, e63b2cf, 90b4625)

docs/README.md

model/registry/vcs.yaml

model/metrics/vcs.yaml

docs/cicd/cicd-metrics.md

model/metrics/vcs.yaml

adrielp · 2024-09-05T01:19:36Z

❌ - login: @christophe-kamphaus-jemmic / name: Christophe Kamphaus . The commit (44a1c81, 4d8e3a9, 592483f, ef91dfa, 238c764, 9bd4a95, 8c2e8a7, f712312, 700412a) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.

@christophe-kamphaus-jemmic - please sign the CLA if you haven't already.

model/registry/vcs.yaml

docs/attributes-registry/vcs.md

model/registry/vcs.yaml

lmolkova

I'm suggesting to change the approach and design those as events given that they would have low volume, but would be very flexible since events can include a lot of context that can be aggregated based on user needs.

See more details in the comment #1383 (comment)

change vcs.change.time_to_approval also into a histogram

Specify that we measure the time to first approval.

….direction

…tor.count

model/vcs/metrics.yaml

…hange into ref

.chloggen/1372-vcs-metrics.yaml

lmolkova · 2024-11-08T17:43:09Z

This looks awesome! 🚀

christophe-kamphaus-jemmic added 9 commits September 3, 2024 22:38

[cicd] add first cicd metric to registry, created cicd-metrics doc

44a1c81

[cicd] link to cicd doc from parent readme

700412a

[cicd] fix typo vsc -> vcs

4d8e3a9

[cicd] fix toc

9bd4a95

[cicd] use {change} as metric unit

592483f

[cicd] formatting and rename metrics section

238c764

[cicd] add remaining metrics from githubreceiver

ef91dfa

https://github.com/adrielp/opentelemetry-collector-contrib/blob/903eec5382352e4d663fadd2dc7f1cc1e37f62fd/receiver/githubreceiver/documentation.md

[cicd] fix markdown code quotation

f712312

[cicd] add changelog entry

8c2e8a7

christophe-kamphaus-jemmic requested review from a team September 3, 2024 20:59

github-actions bot assigned arminru Sep 3, 2024

christophe-kamphaus-jemmic commented Sep 3, 2024

View reviewed changes